I can't confirm the original issue. Can you provide steps to reproduce? Is there something I'm missing here?

@danirabbit The problem occurs if you

• Set search option to be case sensitive
• Select a word (plugin highlights all case-insensitive occurrences )
• Press Ctrl-F to find case-sensitive matches of selected word
• The case-insensitive matches are still highlighted.

This PR makes the plugin highlighting match the search case-sensitivity to fix this.

@zeebok Thanks for the review!

@danirabbit There is an open design question here regarding whether or not the word highlighting plugin should still follow the search options when there is no current search term. In this PR it now does. As this is a change in behaviour design input would be appreciated.

One drawback of this is the search options are hidden in a popover so it may not be immediately obvious why some words are not highlighted if the user forgets they changed the options to do a search. On the other hand the alternative would mean the behaviour of the plugin changing depending the presence or absence of a search term which is also non-obvious.

I'll merge this now, any refinements to behaviour can be done in a separate PR.